search

OoTRandomizer / OoT-Randomizer

A randomizer for Ocarina of Time.
Other
404 stars 233 forks source link

Fix display_song_name #2293

Closed rrealmuto closed 2 months ago

rrealmuto commented 2 months ago

The display_song_name function was incorrectly not setting its combiner mode prior to drawing the display. This doesn't cause any problems in current Dev, however if other functions were to change the combiner mode prior to display_song_name being called, it can cause graphical glitches in the song name display. This PR fixes this by explicitly setting the combiner mode prior to drawing the song display.

This issue occurred on my branch with the enemy minimap tracker changing the combiner mode to PRIMTIVE, PRIMITIVE, prior to display_song_name being called. In this case it would cause the song display to appear as a complete white box as shown in the screenshot below.

Glide64_THE_LEGEND_OF_ZELDA_90

fenhl commented 2 months ago

@rrealmuto just to make sure, has the fix been tested on your branch?

rrealmuto commented 2 months ago

Yes I've incorporated this on my branch and it fixed the issue shown in the screenshot