search

OoTRandomizer / OoT-Randomizer

A randomizer for Ocarina of Time.
Other
404 stars 233 forks source link

fix: _MACOSX directory in ootr archive can cause issues loading tracks #2300

Open EricBartusch opened 2 months ago

EricBartusch commented 2 months ago

In the Darunia's Joy discord, there was a user who was getting an error reading the .meta file for one of their songs.

I eventually figured out that it was because the ootrs archive also contained the author's _MACOSX dir and a ._<filename>.meta that was being read instead of the .meta file at the root.

I think an easy way to fix this for future users, besides having authors making sure their ootrs archives only have files, is to add a check in Music.py so only root files are processed:

TreZc0 commented 2 months ago

While we should add a failsafe on our end, does it not make a lot more sense to add shadow files from mac (or windows), like both of these, to the .gitignore of DJ so they are not committed in the first place?

EricBartusch commented 2 months ago

Unfortunately, the file exists within the .ootrs archive which is just a renamed zip, so a .gitignore won't catch it.

Maybe a workflow could be added to unzip the archive and check for that on PR? edit: https://github.com/DaruniasJoy/OoT-Custom-Sequences/pull/460

DaruniasJoy commented 2 months ago

ahh... that is a reoccuring thing though rarely. did merge that pr on our side.

Damn Apple Users and bringing us issues. NotLikeThis