Players have noticed in the last months that the fish were extremely aggressive and jump on the bait instantly, despite no change having been done on the fishing hacks.
After investigation, the "Easy bite" hack that is supposed to force a guaranteed bite when the hook is static, is relying on a static address (0x801F5DE0) that should point to a speficic pointer in the Fishing actor.
The current behaviour looks like what would happen if that guaranteed bite was happening every frame instead of only when the hook is static.
I'm not sure what broke exactly, but this is dangerous practice anyway, and most certainly pointing to something else on Rob's branch at the very least.
This PR removes the static address dependency by asking a custom c function if the player is either pressing A or moving the stick. If not, then the hook is determined stable and we can safely guarantee a bite.
This should restore the initial intent of the Easy bite hack.
Players have noticed in the last months that the fish were extremely aggressive and jump on the bait instantly, despite no change having been done on the fishing hacks. After investigation, the "Easy bite" hack that is supposed to force a guaranteed bite when the hook is static, is relying on a static address (0x801F5DE0) that should point to a speficic pointer in the Fishing actor. The current behaviour looks like what would happen if that guaranteed bite was happening every frame instead of only when the hook is static. I'm not sure what broke exactly, but this is dangerous practice anyway, and most certainly pointing to something else on Rob's branch at the very least.
This PR removes the static address dependency by asking a custom c function if the player is either pressing A or moving the stick. If not, then the hook is determined stable and we can safely guarantee a bite.
This should restore the initial intent of the Easy bite hack.