OoliteProject / oolite

The main Oolite repository.
https://www.oolite.space
568 stars 73 forks source link

Inacurate documentation on market-prices #293

Open hklene opened 6 years ago

hklene commented 6 years ago

https://github.com/OoliteProject/oolite/blob/master/Doc/OoliteRS.odt https://raw.githubusercontent.com/OoliteProject/oolite/master/Resources/Config/trade-goods.plist The following average prices diverge:

Commodity doc plist
textiles 7.2 71
radioactives 23.2 231
liquor/wines 29.2 291
narcotics 51.0 512
machinery 56.6 560
furs 70.46 704

Moreover "luxuries" with 90.2 is exactly the same value both sides, only it is not the average of: (78.0+102.0)/2 = 90.0 So I guess it should be one of:

  1. 78.4+102.0
  2. 78.3+102.1
  3. 78.2+102.2
  4. 78.1+102.3
  5. 78.0+102.4

But so far I haven't worked out where the calculation formula rounds it's interim results. E.g. looking at "narcotics" again, with price_economic = 0.00 and price_random = 1.00 I'd expect a range of 0.0 to 102.4 or 0.0 to 102.0 depending on the correct average, whereas the given values are 0.4 to 101.6 ???

phkb commented 1 year ago

Apologies for taking so long to respond. The next revision of the OoliteRS.pdf will have updated market information, which will be completely based on observable information in the game (compiled by jumping to every system and compiling the results). The difficulty with the trade-goods.plist info is that weighting and randomisation can skew the results.