Open-Agriculture / AgIsoStack-plus-plus

AgIsoStack++ is the completely free open-source C++ ISOBUS library for everyone
https://agisostack.com/
MIT License
187 stars 41 forks source link

[VT]: Add Virtual Terminal Object Classes #346

Closed ad3154 closed 10 months ago

ad3154 commented 11 months ago

This is intended to be used with a VT server (coming soon? ) or with an object pool editor program. I wanted to open a PR for the ones I have done before the file gets even larger.

Supported objects so far:

ad3154 commented 10 months ago

@GwnDaan I've finished my todos on this for now, so it's ready to review at your convenience.

Despite the amount of code, it's mostly just setters and getters for the various object types, so there's not really that much functionality to worry about. The object pool deserializer and whatnot will come in another PR.

GwnDaan commented 10 months ago

@GwnDaan I've finished my todos on this for now, so it's ready to review at your convenience.

Despite the amount of code, it's mostly just setters and getters for the various object types, so there's not really that much functionality to worry about. The object pool deserializer and whatnot will come in another PR.

Sounds good! I'll try to review it in the coming days, and then I think I'll just mainly have a look at the tests and not so much at the rest, as you suggested👍

sonarcloud[bot] commented 10 months ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 55 Code Smells

78.1% 78.1% Coverage
16.2% 16.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint