search

Open-Agriculture / AgIsoStack-plus-plus

AgIsoStack++ is the completely free open-source C++ ISOBUS library for everyone
https://agisostack.com/
MIT License
168 stars 40 forks source link

[VT]: Add handling of unsupported VT function #404

Closed GwnDaan closed 5 months ago

GwnDaan commented 5 months ago

Closes #377

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
14.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ad3154 commented 5 months ago

Do you think it would be valuable to also have a way to get a list if all previously cached unsupported functions? Or not really?

GwnDaan commented 5 months ago

Do you think it would be valuable to also have a way to get a list if all previously cached unsupported functions?

Hmm, I'm not sure. What do you think it can be used for? You currently only know that a function is unsupported after you tried to send it, so we can't really use that list at startup or something I think

ad3154 commented 5 months ago

Hmm, I'm not sure. What do you think it can be used for? You currently only know that a function is unsupported after you tried to send it, so we can't really use that list at startup or something I think

Maybe unit tests? Haha. I'm not sure, it was just a thought, but I think that doing something on the client side based on some known list of unsupported functions could be challenging, so maybe it's not particularly helpful