search

Open-Agriculture / AgIsoStack-plus-plus

AgIsoStack++ is the completely free open-source C++ ISOBUS library for everyone
https://agisostack.com/
MIT License
168 stars 40 forks source link

[ETP]: Fixed issues where we could CTS too many packets #419

Closed ad3154 closed 5 months ago

ad3154 commented 5 months ago

Describe your changes

This change limits the ETP CTS to be only as many frames as are required to complete a session when receiving an ETP session. This change was required because in #418 I was seeing a situation where a control function was aborting our ETP Rx session because we CTS'd too many packets with the ISO 11783-3 reason "ECTS requested packets exceeds message size" as described in ISO11783-3 Table 9.

Fixes #418

How has this been tested?

I used the TC server branch and the same control function to recreate the failing transfer, and it was successful. Also, validated unit tests continued to pass.

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

GwnDaan commented 5 months ago

Good catch! I totally missed it due to no unit tests hahah