Open-Agriculture / AgIsoStack-plus-plus

AgIsoStack++ is the completely free open-source C++ ISOBUS library for everyone
https://agisostack.com/
MIT License
168 stars 40 forks source link

[Logger]: Made it possible to compile out the logger #421

Closed ad3154 closed 4 months ago

ad3154 commented 5 months ago

Describe your changes

I'm not sure if this is the route we want to go with this, but this change allows compiling out all logging strings.

Sonar is not gonna like this one I suspect. I am open to other approaches - just wanted to submit this one for opinions.

Fixes #416

How has this been tested?

Testing still in progress...

Initial results are that isobus.lib was reduced by 7ish percent with MSVC (debug) and the unit test executable (which generates many log statements) only decreased size by about 1 percent.

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
24.7% Coverage on New Code
2.0% Duplication on New Code

See analysis details on SonarCloud