search

Open-Agriculture / AgIsoStack-plus-plus

AgIsoStack++ is the completely free open-source C++ ISOBUS library for everyone
https://agisostack.com/
MIT License
167 stars 40 forks source link

Rework of NMEA2000 fast packet protocol to match TP/ETP #437

Closed GwnDaan closed 4 months ago

GwnDaan commented 4 months ago

Describe your changes

Reworked the fast packet protocol implementation to align with the updated implementation of the (extended) transport protocol. They use the same base class now for the session, and the dependency on the CanLibProtocol is now completely removed. Also since the FastPacketProtocol class is now a more standalone module we should be able to test it more easily

How has this been tested?

I made sure the 3 examples (namely fast_packet_protocol, nmea2000_generator and nmea2000_parser) are still functioning correctly. And the unit-tests of the nmea2000 message interface are also still working fine, indicating that those messages utilizing the fast packet protocol are still correctly transferred.

Note: This library and its authors are not affiliated with the National Marine Electronics Association in any way.

sonarcloud[bot] commented 4 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

GwnDaan commented 4 months ago

Failed conditions E Reliability Rating on New Code (required ≥ A)

Sorry Sonar, I disagree hahah. None of your issues seem like a problem to me