[TC]: Add product abstraction to DDOP helper

Open-Agriculture / AgIsoStack-plus-plus

AgIsoStack++ is the completely free open-source C++ ISOBUS library for everyone

https://agisostack.com/

MIT License

167 stars 40 forks source link

[TC]: Add product abstraction to DDOP helper #444

Closed ad3154 closed 4 months ago

ad3154 commented 4 months ago

Describe your changes

This provides a way to get rate/product information from a DDOP. Generally it considers any Bin to be the root of a product, which seems to be fairly standard.

This is intended to be used in a TC server to quickly learn about what products the implement might have.

The information provided includes data about:

Default rate
Setpoint rate
Actual rate
Minimum rate
Maximum rate

How has this been tested?

Expanded TC server unit tests to include parsing for product information.

sonarcloud[bot] commented 4 months ago

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
68.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ad3154 commented 4 months ago

Hmmmmm... the more I think about it, the more I think some of these things need their parent element number included in the returned data, that way the TC knows what element to use when commanding or requesting the value without needing to search the whole DDOP again. I will merge this, but I think I will follow up with another PR that expands the data returned

Edit: Added in f7d1a873cb4c6cf6a995e4cb6f177aad14ebcacd