[Core]: Refactorization of control function address claiming and factory methods

GwnDaan commented 2 months ago

Describe your changes

With the goal in mind of getting rid of the singleton from the network manager, I removed a bit of dependencies of the control functions on the network manager. This should be another step closer to making it easy to flip the network manager around.

What changed:

Moved the factory functions to the network manager:
- InternalControlFunction::create -> CANNetworkManager::create_internal_control_function
- PartneredControlFunction::create -> CANNetworkManager::create_partnered_control_function
Removed the AddressClaimStateMachine class, and instead housed it directly into the InternalControlFunction class. They already had an 1:1 relation, so it basically was nothing more than an extension at this point.

How has this been tested?

Made sure that the unit tests still correctly ran without making functional changes. Only minor thing is the removal of the check that a control function is correctly removed when it's "destroyed". I think that's something to look at later and currently gave more of a headache than it was useful. So I removed that GTEST assert.

Furthermore, I ran the seeder and VT3 object pool examples, they both still work fine. For most of the examples I removed the set preferred address, since according to the standard they have no function specifically defined for the currently configured preferred address:

A CF claiming a preferred address in the range 0 to 127 and 248 to 253 shall perform the function defined for that preferred address and shall specify that function within its NAME.