[HW]: Fixed possibly dropping messages on Tx when Tx buffer is full

Open-Agriculture / AgIsoStack-plus-plus

AgIsoStack++ is the completely free open-source C++ ISOBUS library for everyone

https://agisostack.com/

MIT License

167 stars 40 forks source link

[HW]: Fixed possibly dropping messages on Tx when Tx buffer is full #479

Closed ad3154 closed 2 weeks ago

ad3154 commented 2 weeks ago

Describe your changes

Fixed an issue where we weren't checking the return value of the push into our Tx queue in our hardware interface. This could have caused some frames to be accidentally dropped.

How has this been tested?

Recreated the issue discussed here with AgIsoVirtualTerminal with the number of frames per DOP set to 255, and witnessed frames being dropped.

Added this check, and now object pool properly uploads!

This may fix #476

sonarcloud[bot] commented 2 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
62.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud