Open-Agriculture / AgIsoVirtualTerminal

A free, experimental ISO11783-6 Virtual Terminal (VT) server GUI based on AgIsoStack++
GNU General Public License v3.0
20 stars 1 forks source link

Button held messages kept sent when pressing non key or button items #37

Closed martonmiklos closed 1 week ago

martonmiklos commented 2 weeks ago

Hello all,

If I click on an inputnumber the key press state got cached here for all object type: https://github.com/Open-Agriculture/AgIsoVirtualTerminal/blob/main/src/DataMaskRenderAreaComponent.cpp#L99

However this only get cleared for key and button object types (on release): https://github.com/Open-Agriculture/AgIsoVirtualTerminal/blob/main/src/DataMaskRenderAreaComponent.cpp#L159 https://github.com/Open-Agriculture/AgIsoVirtualTerminal/blob/main/src/DataMaskRenderAreaComponent.cpp#L141

This will result the button held messages to be sent continuously: image

I have filtered the save in the press event to key and button and it looks to be working correctly, but I wanted have some discussion before PR.