Open-Attestation / oa-verify

Verification library for OpenAttestation document
Apache License 2.0
6 stars 18 forks source link

fix: force microbundler to inline and transpile ethr-did-resolver #304

Closed phanshiyu closed 4 weeks ago

phanshiyu commented 4 weeks ago

Why

The ESM build of ethr-did-resolver seems to be mixing cjs, which will fail in esm only environments. Something like that https://github.com/decentralized-identity/ethr-did-resolver/issues/186.

What

Ideally ethr-did-resolver should be rebuilt to only contain ESM code, but since we have no control over that and I do not want to fork them, we can inline the code directly during bundling, this is done by shifting ethr-did-resolver to dev deps (a microbundler behaviour).

github-actions[bot] commented 4 weeks ago

:tada: This PR is included in version 9.3.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: