search

Open-Attestation / open-attestation

Meta framework for providing digital provenance and integrity to documents.
https://openattestation.com
Apache License 2.0
55 stars 19 forks source link

fixL scoped context under OpenAttestationCredential #184

Closed Fak3 closed 3 years ago

Fak3 commented 3 years ago

This PR proposes a way to fix #183. I have introduced new more specific credential type - OpenAttestationCredential, and this context only applies to the credential which has this type assigned. So that the credential issuer can override the vocabulary for terms under the credentialSubject.

Fak3 commented 3 years ago

Hide whitespace changes to view actually added lines

Nebulis commented 3 years ago

Thanks for the MR, looks good, will merge soon

Nebulis commented 3 years ago

Could you update your MR with an empty commit for instance ? Ci didn't run, I changed something and wan to see if it works :thinking:

Fak3 commented 3 years ago

done

Nebulis commented 3 years ago

Erf.... I dunno why circle CI doesnt run, will merge and fix if neeeded

john-dot-oa commented 3 years ago

:tada: This PR is included in version 5.3.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

rjchow commented 3 years ago

Erf.... I dunno why circle CI doesnt run, will merge and fix if neeeded

I think CI might be disabled for external PRs