search

Open-CMSIS-Pack / Open-CMSIS-Pack-Spec

Common Microcontroller Software Interface Standard - Pack(age) based distribution system
https://open-cmsis-pack.github.io/Open-CMSIS-Pack-Spec/
Apache License 2.0
50 stars 20 forks source link

Add `Hvendor` and `Hname` as attributes of `accept`, `require` and `deny` elements #228

Closed silviooliva closed 1 year ago

silviooliva commented 1 year ago

Commit related to issue #182. This allows part specific filtering.

silviooliva commented 1 year ago

Thanks a lot for the PR. Please see my comment. Are you happy to change to Hvendor to xs:string. This is similar to Bvendor where we don't have an fixed list with vendorID numbers.

@jkrech, I've used the DeviceVendorEnum since the the Hvendor has been defined as DeviceVendorEnum type (see the part element description). Changing the Hvendor here to xs:string, maybe we should also change the Hvendor attribute definition in the part element (no problem on my side to fix it as well). Or do you think we could keep the two definitions disaligned?

jkrech commented 1 year ago

@silviooliva, good catch. I do agree that we should also make it xs:string for the part element: https://open-cmsis-pack.github.io/Open-CMSIS-Pack-Spec/main/html/pdsc_parts_pg.html#element_part Could you please do so?

silviooliva commented 1 year ago

@jkrech, after further thinking, I'm convinced too it is better, for the same reason you exposed here, to use xs:string for the Hvendor. I'm going to fix it.