Closed silviooliva closed 1 year ago
@silviooliva
So far we have tried to map device's elements to part's elements whereas image is taken from the board but I clearly prefer it over abusing the book
element.
I would suggest to replace large
and small
with top
. We could not do it at the time of adding bottom and perspective for backward compatibility.
Is the expectation that at least one image is mandatory or if specified all three variants need to be specified?
@silviooliva, are you happy to prepare a PR for this?
Hi @jkrech,
if I understand correctly, you are suggesting to define a new image
element for the part
(with top
attribute instead of large
and small
), keeping the image
for the board
as it is now.
For the part the expectation is that, if the image
child element is present, at least one of its attributes needs to be specified.
Anyway, I'll prepare this PR for your review.
@silviooliva, we need to keep the specification of the board unchanged to not break existing descriptions.
We can have a clean
specification for the part element, using top
, bottom
, perspective
. I would suggest to make the top
attribute required, whereas the other two are optional.
@jkrech, PR https://github.com/Open-CMSIS-Pack/Open-CMSIS-Pack-Spec/pull/250 opened for this issue.
Like for the
board
element and since using thebook
element for that is not recommended, it could be useful for thepart
element having a dedicated child element for referencing at least onepart
image.A solution could be to reuse the
/package/boards/board/image
definition (reported below) adapting it also for thepart
.