search

Open-CMSIS-Pack / Open-CMSIS-Pack-Spec

Common Microcontroller Software Interface Standard - Pack(age) based distribution system
https://open-cmsis-pack.github.io/Open-CMSIS-Pack-Spec/
Apache License 2.0
50 stars 19 forks source link

csolution element: inconsistent documentation #311

Closed DavidLesnjak closed 1 month ago

DavidLesnjak commented 2 months ago

  1. csolution clayer:

    • It seems that attribute name is available in the schema. Is it missing in the specification?
    • Example: Missing attribute type, which is required by the specification: 
      <clayer type="Board" path="layers/board/FRDM-MCXA153-MW" file="Board.clayer.yml" copy-to="board/FRDM-MCXA153" condition="FRDM-MCXA153-Board" />
<clayer type="Board" path="board/FRDM-MCXA153" file="Board.clayer.yml" condition="FRDM-MCXA153-Board"/>

  2. csolution and template:

    • Typo in example: "copyto" instead of "copy-to" (Note: in two places): 
      <template name="Basic csolution project" path="templates/blank" file="Blank.csolution.yml" copy-to="Blank" condition="STM32H7S-Series">
jkrech commented 2 months ago

@ReinhardKeil, please see the feedback on the specification update above.

ReinhardKeil commented 1 month ago

@DavidLesnjak

It seems that attribute name is available in the schema. Is it missing in the specification?

where is the attribute "name" defined in the schema? I cannot find it here: https://github.com/Open-CMSIS-Pack/Open-CMSIS-Pack-Spec/blob/main/schema/PACK.xsd#L1716

DavidLesnjak commented 1 month ago

Sorry, there is no problem with attribute "name". I must have wrongly relied on the shema-checker in notepad++.

ReinhardKeil commented 1 month ago

fixed