search

Open-CMSIS-Pack / cbuild2cmake

A command line tool that generates CMakeLists.txt file from *.cbuild.yml files generated by csolution
Apache License 2.0
3 stars 2 forks source link

Add bin and hex outputs to ExternalProject_Add BUILD_BYPRODUCTS #127

Closed EaselinkBachmann closed 1 month ago

EaselinkBachmann commented 1 month ago

This PR allows executes commands to depend on .bin and .hex files from projects.

The previous implementation assumed every context only has one output file, and had one global set(OUTPUTS ...) array with a single entry per context. This PR replaces this array with per-context set(OUTPUTS_1 ...), set(OUTPUTS_2 ...), ... arrays, and gets the corresponding array with ${OUTPUTS_${N}} for the ExternalProject_Add call.

The resulting change to the generated CMake is thus fairly minimal, while still allowing executes to use .bin and .hex files from projects.

Fixes #126

codeclimate[bot] commented 1 month ago

Code Climate has analyzed commit 7a292eb8 and detected 0 issues on this pull request.

View more on Code Climate.

EaselinkBachmann commented 1 month ago

sure!

EaselinkBachmann commented 1 month ago

Should be fixed now.