search

Open-CMSIS-Pack / devtools

Open-CMSIS-Pack development tools - C++
Apache License 2.0
74 stars 57 forks source link

Update and rename AC6.6.18.0.cmake to AC6.6.16.2.cmake #1491

Closed jkrech closed 5 months ago

jkrech commented 5 months ago

Arm Compiler 6.16.2 is a long term maintenance version of the Arm Compiler 6 and shall be supported by CMSIS-Toolbox as well. The cmake supports CPUs that are not supported by the 6.16.2 compiler version. For these CPUs the compiler will report an error on invocation.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 63.10%. Comparing base (12a61cc) to head (2947e14).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1491 +/- ## ======================================= Coverage 63.10% 63.10% ======================================= Files 162 162 Lines 30616 30616 Branches 18750 18750 ======================================= Hits 19321 19321 + Misses 7528 7512 -16 - Partials 3767 3783 +16 ``` | [Flag](https://app.codecov.io/gh/Open-CMSIS-Pack/devtools/pull/1491/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Open-CMSIS-Pack) | Coverage Δ | | |---|---|---| | [buildmgr-cov](https://app.codecov.io/gh/Open-CMSIS-Pack/devtools/pull/1491/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Open-CMSIS-Pack) | `74.12% <33.33%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Open-CMSIS-Pack#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/Open-CMSIS-Pack/devtools/pull/1491?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Open-CMSIS-Pack) | Coverage Δ | | |---|---|---| | [...r/test/integrationtests/src/CBuildIntegTestEnv.cpp](https://app.codecov.io/gh/Open-CMSIS-Pack/devtools/pull/1491?src=pr&el=tree&filepath=tools%2Fbuildmgr%2Ftest%2Fintegrationtests%2Fsrc%2FCBuildIntegTestEnv.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Open-CMSIS-Pack#diff-dG9vbHMvYnVpbGRtZ3IvdGVzdC9pbnRlZ3JhdGlvbnRlc3RzL3NyYy9DQnVpbGRJbnRlZ1Rlc3RFbnYuY3Bw) | `65.21% <100.00%> (ø)` | | | [...buildmgr/test/integrationtests/src/DebPkgTests.cpp](https://app.codecov.io/gh/Open-CMSIS-Pack/devtools/pull/1491?src=pr&el=tree&filepath=tools%2Fbuildmgr%2Ftest%2Fintegrationtests%2Fsrc%2FDebPkgTests.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Open-CMSIS-Pack#diff-dG9vbHMvYnVpbGRtZ3IvdGVzdC9pbnRlZ3JhdGlvbnRlc3RzL3NyYy9EZWJQa2dUZXN0cy5jcHA=) | `0.00% <ø> (ø)` | | | [...ldmgr/test/integrationtests/src/InstallerTests.cpp](https://app.codecov.io/gh/Open-CMSIS-Pack/devtools/pull/1491?src=pr&el=tree&filepath=tools%2Fbuildmgr%2Ftest%2Fintegrationtests%2Fsrc%2FInstallerTests.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Open-CMSIS-Pack#diff-dG9vbHMvYnVpbGRtZ3IvdGVzdC9pbnRlZ3JhdGlvbnRlc3RzL3NyYy9JbnN0YWxsZXJUZXN0cy5jcHA=) | `0.00% <0.00%> (ø)` | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/Open-CMSIS-Pack/devtools/pull/1491/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Open-CMSIS-Pack)
jkrech commented 5 months ago

This PR was updated to make the suggested changes. Please re-review. https://github.com/Open-CMSIS-Pack/cmsis-toolbox/pull/123 depends on this PR being merged first. I added Sourabh as reviewer here as well.

github-actions[bot] commented 5 months ago

Test Results

  7 files   53 suites   5m 30s :stopwatch: 186 tests 169 :white_check_mark: 17 :zzz: 0 :x: 695 runs  627 :white_check_mark: 68 :zzz: 0 :x:

Results for commit 2947e14a.

brondani commented 5 months ago

Open-CMSIS-Pack/cmsis-toolbox#123 depends on this PR being merged first.

Please note that depends not only on this PR being merged but also on buildmgr being released and the toolbox workflow being updated accordingly.

jkrech commented 5 months ago

Thanks a lot for clarifying.