Open-CMSIS-Pack / devtools

Open-CMSIS-Pack development tools - C++
Apache License 2.0
69 stars 50 forks source link

Do not create RTE_Components.h if no component is selected (#926) #1527

Closed grasci-arm closed 1 month ago

grasci-arm commented 1 month ago

Co-authored-by: Daniel Brondani daniel.brondani@arm.com

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.36%. Comparing base (21ba587) to head (da13431).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1527 +/- ## ======================================= Coverage 63.36% 63.36% ======================================= Files 162 162 Lines 30910 30911 +1 Branches 18943 18944 +1 ======================================= + Hits 19586 19587 +1 - Misses 7521 7523 +2 + Partials 3803 3801 -2 ``` | [Flag](https://app.codecov.io/gh/Open-CMSIS-Pack/devtools/pull/1527/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Open-CMSIS-Pack) | Coverage Δ | | |---|---|---| | [buildmgr-cov](https://app.codecov.io/gh/Open-CMSIS-Pack/devtools/pull/1527/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Open-CMSIS-Pack) | `74.12% <ø> (ø)` | | | [packchk-cov](https://app.codecov.io/gh/Open-CMSIS-Pack/devtools/pull/1527/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Open-CMSIS-Pack) | `65.54% <ø> (ø)` | | | [projmgr-cov](https://app.codecov.io/gh/Open-CMSIS-Pack/devtools/pull/1527/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Open-CMSIS-Pack) | `80.46% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Open-CMSIS-Pack#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/Open-CMSIS-Pack/devtools/pull/1527?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Open-CMSIS-Pack) | Coverage Δ | | |---|---|---| | [tools/projmgr/src/ProjMgrYamlEmitter.cpp](https://app.codecov.io/gh/Open-CMSIS-Pack/devtools/pull/1527?src=pr&el=tree&filepath=tools%2Fprojmgr%2Fsrc%2FProjMgrYamlEmitter.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Open-CMSIS-Pack#diff-dG9vbHMvcHJvam1nci9zcmMvUHJvak1ncllhbWxFbWl0dGVyLmNwcA==) | `94.54% <100.00%> (+<0.01%)` | :arrow_up: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/Open-CMSIS-Pack/devtools/pull/1527/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Open-CMSIS-Pack)
github-actions[bot] commented 1 month ago

Test Results

  7 files   53 suites   4m 50s :stopwatch: 186 tests 169 :white_check_mark: 17 :zzz: 0 :x: 695 runs  627 :white_check_mark: 68 :zzz: 0 :x:

Results for commit da13431d.

:recycle: This comment has been updated with latest results.

ReinhardKeil commented 1 month ago

I'm not sure that this requirement is correct. There is a define "cmsis_device_header" in RTE_components.h that should be also there when no component is selected