search

Open-CMSIS-Pack / devtools

Open-CMSIS-Pack development tools - C++
Apache License 2.0
76 stars 59 forks source link

cbuild disables schema check by default #1777

Closed ReinhardKeil closed 1 week ago

ReinhardKeil commented 2 months ago

The Problem To Be Solved

cbuild has schema check disabled by default. User errors (such as blanks in built-type names) are therefore not flagged.

Suggest A Solution

Consider to change the default to "schema check enabled".

See also #1767

jkrech commented 2 months ago

Review the purpose of the tools. Initially we were separating solution configuration = csolution from solution build = cbuild. With the introduction of cbuild setup an alternative to csolution was introduced. Maybe cbuild setup should do a schema check but not cbuild?

jkrech commented 2 months ago

Add schema check to all invocations by default.

soumeh01 commented 1 month ago

@ReinhardKeil I want to highlight that changing the default behavior is technically feasible and can be done with ease. As part of this change, the -s, schema option in cbuild becomes redundant and can be removed. However, we should introduce a new option, such as --no-check-schema (similar to csolution), to disable the default behavior when needed.

Since removing the -s, schema option might introduce a breaking change for some users, I recommend implementing this in a major version release to ensure smooth transitions.