search

Open-CMSIS-Pack / devtools

Open-CMSIS-Pack development tools - C++
Apache License 2.0
76 stars 59 forks source link

buildmgr: Patch CLANG.cmake to be compatible with LLVM 19 #1807

Closed JonatanAntoni closed 1 month ago

JonatanAntoni commented 1 month ago

In LLVM 19 the order of the target triple got swapped. I.e., none-unknown-eabi is not accepted anymore instead unknown-none-eabi is required. By dropping the unknown entirely the reduced target triple is accepted by all major versions 17, 18, and 19 by defaulting to vendor unknown.

See llvm/llvm-project#89582

github-actions[bot] commented 1 month ago

Test Results

  7 files   53 suites   4m 7s :stopwatch: 185 tests 168 :white_check_mark: 17 :zzz: 0 :x: 692 runs  624 :white_check_mark: 68 :zzz: 0 :x:

Results for commit eb969f00.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.24%. Comparing base (d085a91) to head (eb969f0). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1807 +/- ## ======================================= Coverage 64.24% 64.24% ======================================= Files 163 163 Lines 32128 32128 Branches 19636 19636 ======================================= Hits 20641 20641 - Misses 7571 7574 +3 + Partials 3916 3913 -3 ``` | [Flag](https://app.codecov.io/gh/Open-CMSIS-Pack/devtools/pull/1807/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Open-CMSIS-Pack) | Coverage Δ | | |---|---|---| | [buildmgr-cov](https://app.codecov.io/gh/Open-CMSIS-Pack/devtools/pull/1807/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Open-CMSIS-Pack) | `74.21% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Open-CMSIS-Pack#carryforward-flags-in-the-pull-request-comment) to find out more. [see 3 files with indirect coverage changes](https://app.codecov.io/gh/Open-CMSIS-Pack/devtools/pull/1807/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Open-CMSIS-Pack)