search

Open-CMSIS-Pack / devtools

Open-CMSIS-Pack development tools - C++
Apache License 2.0
70 stars 51 forks source link

[csolution] package requirements info are not taken into account? #659

Closed jeromecoutant closed 10 months ago

jeromecoutant commented 1 year ago

Hi

In some packs, we have:

  <requirements>
    <packages>
      <package vendor="STMicroelectronics" name="aaa" version="X.Y.Z"/>
    </packages>
  </requirements>

It seems that csolution convert procedure doesn't check this part ? I can set any lines, there is no check with the packs indicated in the csolution file.

Regards,

jkrech commented 1 year ago

@jeromecoutant: Thanks for raising this. I think we need to review this feature. In the csolution.yml we today specify the required packs but do not rely on the requirements for other pack versions provided in the pdsc files to complement that list. Instead these package level requirements are today considered by the PackManager implementation in MDK and Eclipse. The package managers display an Install + instead of Install if there is other requirement for other packs. If the required pack is missing this will be shown in the output window and in the GUI there is a button Resolve. cpackget does not implement this feature today but this is being requested in Extend cpackget to handle pack requirements In my view cpackget is the tool that should be concerned about this rather than csolution.

Note: once csolution starts using the *.cbuild.yml files as "additional input" all used pack versions are known even in case the csolution.yml files do not list any packs or just packs with wildcards.

fred-r commented 1 year ago

I think the point from @jeromecoutant is that:

So, if csolution.yml defines the list of packs to be used, then probably csolution should check the dependencies to make sure we have all required packs?

Thanks & Regards, Fred

jeromecoutant commented 1 year ago

if csolution.yml defines the list of packs to be used, then probably csolution should check the dependencies to make sure we have all required packs?

That is what I thought : required packs with the minimal version Thx

jkrech commented 1 year ago

Thanks for clarifying. Is this a priority for cmsis-toolbox 2.0. Is anyone volunteering for adding this check?

edriouk commented 10 months ago

implementd by PR https://github.com/Open-CMSIS-Pack/devtools/pull/1105