search

Open-CMSIS-Pack / vidx2pidx

Utility that converts a vendor index file into a vendor independent package index file
Apache License 2.0
3 stars 3 forks source link

GitHub actions #2

Closed chaws closed 3 years ago

chaws commented 3 years ago

This PR shows how Github actions CI ensures code quality by running tests, lint and format-checking.

jscook2345 commented 3 years ago

Looks really good!

One suggestion:

Use the gitlabci-lint action instead. See the example here:

https://github.com/sirupsen/logrus/blob/master/.github/workflows/ci.yaml

jscook2345 commented 3 years ago

Once you merge this I will help add some more linters that are disabled by default but very useful as well!

chaws commented 3 years ago

Thanks @jscook2345 ! I've incorporated your suggestions and also split the thing into 3 jobs: lint, format and coverage (which runs tests).

I'm merging this now so that next PR's will run through the checks. Will be waiting for more linters :)