search

Open-CMSIS-Pack / vidx2pidx

Utility that converts a vendor index file into a vendor independent package index file
Apache License 2.0
3 stars 3 forks source link

Force option #4

Closed chaws closed 3 years ago

chaws commented 3 years ago

Passing -f/--force will force vidx2pidx to go inside pdsc files cross-checking Vendor, URL, Name and Version against the pdsc tags provided in pidx and vidx files.

Also, by default files are going to be saved in .idxcache folder, but that can be customized by using -c/--cachedir flag

jscook2345 commented 3 years ago

LGTM!

chaws commented 3 years ago

Thanks for reviewing @jscook2345 ! I'll merge this now, but I left the comments above. I'd like to know your opinion on monkey patching, I didn't find another popular repo yet.

jscook2345 commented 3 years ago

I'm not a huge fan of monkey patching, but since you're keeping it to a minimum I think it's fine for now. Most testing libraries would try to use a Mocking framework in this case I think.