search

Open-Cap-Table-Coalition / Open-Cap-Format-OCF

Open Cap Format (OCF) - The Open Source Company Capitalization Data Standard. OCF can be used to structure and track the complex data structures necessary to build and maintain accurate capitalization (cap) tables.
https://opencaptablecoalition.com
Other
143 stars 30 forks source link

[Bug]: Fixing Issuer Authorized Shares Adjustment Validation #457

Closed victormimo closed 6 months ago

victormimo commented 10 months ago

Current Behavior:

  1. ObjectType.schema.json is missing the enum TX_ISSUER_AUTHORIZED_SHARES_ADJUSTMENT, resulting in a failure when validating sample data.
  2. IssuerTransaction.schema.json references required field stock_class_id when it's not in the properties, I believe it was meant to include issuer_id

Expected Behavior:

  1. Include the missing enum
  2. Change required field to issuer_id

Steps to Reproduce:

  1. Add a TX_ISSUER_AUTHORIZED_SHARES_ADJUSTMENT to the sample transaction data
  2. Validate it

Anything else we need to know?

@JSv4 if you give me write access to the repo, I'm happy to create a PR to make reviewing easier.

JSv4 commented 8 months ago

Hey @victormimo, we connected on this issue offline. Can you fork the repo and open a PR from the fork?

victormimo commented 7 months ago

Will do.