search

Open-Capital / OpenCapital

New Interfaces for Marx's Capital and related texts
2 stars 0 forks source link

Hard-coded references to Sefaria #4

Open realityfabric opened 6 years ago

realityfabric commented 6 years ago

In the parent project, Sefaria, there are places where there are links to their website which are hard-coded into the project. There is also contact information hard-coded into some of the code.

This all needs to be removed or altered.

Not as critical, and possibly not necessary, are the variables named "sefaria" and similar.

EliezerIsrael commented 6 years ago

You might be interested in the 4x branch, which has our early experiments in making Sefaria work for other corpora. The idea is that site specific data is separated out from core functionality.

It's not fully documented yet, and there's still a lot of Hebrew that sneaks in, but see the first attempts: https://github.com/EliezerIsrael/joyce_site https://github.com/EliezerIsrael/s4all

realityfabric commented 6 years ago

Thanks! I'll definitely take a look at that branch, and joyce_site and s4all look promising at first glance!