Open-EO / FuseTS

Time series Fusion toolbox integrated with openEO
https://open-eo.github.io/FuseTS/
Other
22 stars 4 forks source link

CropSAR_px should output a mask array for the requested geometry #101

Closed JanssenBrm closed 1 year ago

JanssenBrm commented 1 year ago

Description

Currently, the output of the CropSAR_px process returns a single data array, extending the envelope around the requested geometry. Since the data array is obtained in the raster format, we have no way of knowing which pixels belong to the inside and which to the outside of the geometry.

Recommendations

The process should return a Boolean mask containing the information which pixels represent the inside of the requested geometries, so that the pixel-level outputs can be aggregated in a more direct way.

JanssenBrm commented 1 year ago

@GriffinBabe - I think this issue is fixed. I've tried this with the latest version of the CropSAR_px service through the notebook provided in this repo (https://github.com/Open-EO/FuseTS/blob/main/notebooks/OpenEO/FuseTS%20-%20CropSAR.ipynb). As shown in the image below, it looks like the image is correctly cropped to the provided geometry.

image

I'm closing this for now, but feel free to re-open it if I totally misunderstood the issue.