Open-EO / openeo-aggregator

openEO driver that combines multiple other drivers
https://open-eo.github.io/openeo-aggregator/
Apache License 2.0
1 stars 1 forks source link

collection metadata merging: min/max statistics handling #80

Open soxofaan opened 2 years ago

soxofaan commented 2 years ago

While checking https://github.com/openEOPlatform/architecture-docs/issues/288 issues related to stac summaries statistics, e.g. :

TypeError("Error parsing 'eo:cloud_cover' of StacSummaries: Could not parse Statistics object, actual: {'maximum': 100, 'minimum': 0}")

This implementation looks for "min" and "max" fields https://github.com/Open-EO/openeo-aggregator/blob/804ca2214f627fe693e07b1cb9537c42f176449a/src/openeo_aggregator/metadata/models/statistics.py#L14-L52

but https://github.com/radiantearth/stac-spec/blob/v1.0.0-rc.2/collection-spec/collection-spec.md#stats-object works with "minimum" and "maximum"

@JeroenVerstraelen did you get min/max from a spec, or something else? How can it be changed to minimum/maximum?

related to #76

JeroenVerstraelen commented 2 years ago

That requirement comes from the openeo api specification: https://github.com/Open-EO/openeo-api/blob/master/openapi.yaml#L4467

soxofaan commented 2 years ago

Interesting, @m-mohr is there an inconsistency here about stats objects as collection summaries?

m-mohr commented 2 years ago
m-mohr commented 2 years ago

See https://github.com/Open-EO/openeo-api/commit/8a112b7fa44056abbc30f484634d63a519e23352