Open-EO / openeo-api

The openEO API specification
http://api.openeo.org
Apache License 2.0
91 stars 11 forks source link

billing currency: required but with default? #423

Closed soxofaan closed 2 years ago

soxofaan commented 2 years ago

https://github.com/Open-EO/openeo-api/blob/592e2662c23843745e2e8c28269b19685cf13cd1/openapi.yaml#L724-L737

Currency is required, but has a default value (referred to in description If set to the default valuenull``), which is bit confusing I think.

m-mohr commented 2 years ago

Oh yes, we need to remove the default value. :-)

m-mohr commented 2 years ago

Fixed in 59b4bab5

soxofaan commented 2 years ago

I think you should also remove the "default" from https://github.com/Open-EO/openeo-api/blob/59b4bab5f1e5f30ca9b938c378740759e83343c4/openapi.yaml#L733

m-mohr commented 2 years ago

Indeed, thanks for catching this.