search

Open-EO / openeo-api

The openEO API specification
http://api.openeo.org
Apache License 2.0
93 stars 12 forks source link

Naming convention inside summaries field of collections isn't compliant with STAC Specification #493

Closed GeraldIr closed 1 year ago

GeraldIr commented 1 year ago

https://github.com/radiantearth/stac-spec/blob/master/collection-spec/collection-spec.md says that summaries can contain either an array of any value or a range which is a dictionary of a minimum and a maximum.

The naming convention here differs in the openEO API spec as "min" and "max" are used instead of "minimum" and "maximum".

Should be an easy fix as you just need to rename the 'min' and 'max' in the 'collection_summary_stats' in the specification file (line 4190 in the json, 4450 in the yaml), examples should also be adjusted.

m-mohr commented 1 year ago

Good point. This comes up because in STAC 0.9 it was min/max and in STAC 1.0 it's minimum/maximum. As we support both it's a bit difficult to properly express this in OpenAPI, but I guess we should update to 1.0.

PRs are welcome.

m-mohr commented 1 year ago

It was actually only the examples that were not updated, this will be fixed in the next release (1.2.0).