Open-EO / openeo-backend-validator

Service to validate back-end compliance with the API specification.
Apache License 2.0
1 stars 3 forks source link

group summary with "Missing" endpoint #42

Closed soxofaan closed 4 years ago

soxofaan commented 4 years ago

while playing with missing/unsupported endpoint I got this result of an endpoint group (trimmed down for readability):

"User-Defined Processes": {
            "endpoints": {
                "process_graphs": {
                    "message": "",
                    "state": "Valid",
                    "type": "GET",
                    "url": "/process_graphs"
                },
                "validation": {
                    "message": "Input: /validation; Error: Response Code 404; Details: elaba",
                    "state": "Missing",
                    "type": "POST",
                    "url": "/validation"
                }
            },
            "group_summary": "Valid"
        }

So there is one "Missing" endpoint (one that is listed in capabilities endpoints, but returns 404 when requested) in the group, but the group still gets label "Valid". Is that intended?

bgoesswe commented 4 years ago

I think it was intended when "NotSupported" was not implemented, but now I need to change that.

bgoesswe commented 4 years ago

Ok with 50ad24d45992e618c25832996bbeacaadfb02f63 the state is now as follows:

bgoesswe commented 4 years ago

Yes, sry I forgot to mention that it is only about the group summary state, so e.g. in the example above the "group_summary".

Yes so if there is one valid and at least one of the other occurences

m-mohr commented 4 years ago

Yeah, nevermind. I understood it a minute after posting ;-)

soxofaan commented 4 years ago

seems to work better now, thanks