search

Open-EO / openeo-earthengine-driver

openEO back-end driver for Google Earth Engine.
Apache License 2.0
21 stars 7 forks source link

minor bug fix, updated documentation with user account creation guide #29

Closed jaysnm closed 7 months ago

jaysnm commented 4 years ago

I noted node 12.x raises a high vulnerability concern which ain't raised on node 10.x. However, npm audit fix clears them all.

m-mohr commented 4 years ago

Thank you for your pull request. Unfortunetaly, I think the PR won't work as proposed. The name specified during registration is not used anywhere else you'd still need to log-in with the actual id. We'll probably fix this behavior in the future and come back to your PR then, but it's likely not anytime soon.

I'm aware that there's a vulnerability reported by npm for the earthengine-api, but npm audit fix doesn't fix it correctly as it's not fixed in the earthengine-api yet. See https://github.com/google/earthengine-api/issues/103. Maybe there's another one that I'm not aware of yet as I'm still on node 11.

jaysnm commented 4 years ago

I appreciate you reverted. Thank you.

m-mohr commented 7 months ago

Closing in favor of the new npm run adduser command that will be introduced soon through PR #70.