Open-EO / openeo-earthengine-driver

openEO back-end driver for Google Earth Engine.
Apache License 2.0
21 stars 7 forks source link

mask process has no replacement value #52

Closed clausmichele closed 3 years ago

clausmichele commented 3 years ago

I see some news in various processes using in the latest Web Editor (used with GEE backed):

  1. merge_cubes doesn't have overlap_resolver anymore, which is good since it never worked
  2. mask is missing the replacement value. Did the process definition change? Is it set to zero or Nan by default? We need it for an if-else condition for our use case.

Cheers, Michele

m-mohr commented 3 years ago

Likely not a Web Editor issue, but a GEE issue, so transferred it.

  1. Yes, we updated merge_cubes to not have the overlap_resolver anymore.
  2. mask hasn't changed in GEE since June, but it never had the replacement value implemented yet. So that's something that still needs to be implemented. @bgoesswe What do you think: How much work would that be?
m-mohr commented 3 years ago

I just implemented the replacement value. Will update the public instance after PR #56 has been reviewed and merged.

m-mohr commented 3 years ago

Has been deployed @clausmichele