search

Open-EO / openeo-geopyspark-driver

OpenEO driver for GeoPySpark (Geotrellis)
Apache License 2.0
25 stars 4 forks source link

Allow to load signed result URL in load_ml_model #732

Closed EmileSonneveld closed 4 weeks ago

EmileSonneveld commented 3 months ago

Loading from a signed results URL avoids credentials issues.

Another way could have been to sign the content of the /ml_model_metadata.json url.

JeroenVerstraelen commented 3 months ago

The code looks good but I'm not sure why ml_model_metadata.json has a different json structure compared to other files. I suspect the signed urls are the ones that don't end with 'ml_model_metadata.json'? If so, we should be careful with splitting up based on the name of the file. Users should be able to choose any filename they want.

EmileSonneveld commented 3 months ago

PR put on draft and might close later. I'll implement the other way, signing the urls in /ml_model_metadata.json when the request self is signed...