make property filter operators explicit

bossie commented 1 month ago

The way the properties argument of load_collection is currently passed throughout the application is problematic. Historically it assumes an exact match of a single value ("eq") but that no longer holds; the actual operator is lost along the way (in most cases).

Some related issues:

Blocks https://github.com/Open-EO/openeo-python-driver/issues/145:

the actual comparison operator is stripped somewhere in the pipeline
A TODO for https://github.com/Open-EO/openeo-geotrellis-extensions/issues/39 re: what seems like a way to support cloud cover "lte" (not sure how OSCARS interprets this): https://github.com/Open-EO/openeo-geopyspark-driver/blob/f2c07399ae0482640d1c1d9d5cfdfc001b7b1d81/openeogeotrellis/layercatalog.py#L306-L307
Technical debt from https://github.com/Open-EO/openeo-opensearch-client/issues/32 where "eq" is actually interpreted as "in"; this issue has more in-depth knowledge re: this technical debt.

bossie commented 1 month ago

It seems to boil down to getting rid of this flatten_eqs parameter and passing the operator around as well:

https://github.com/Open-EO/openeo-geopyspark-driver/blob/630439c6170c9ec5668e8d815b9fe0818287f430/openeogeotrellis/layercatalog.py#L295-L310

bossie commented 1 month ago

Not fixed, just some preparatory work.

Open-EO / openeo-geopyspark-driver

make property filter operators explicit #776