search

Open-EO / openeo-geopyspark-driver

OpenEO driver for GeoPySpark (Geotrellis)
Apache License 2.0
26 stars 4 forks source link

Support for parameters in max_cloud_cover in load_collection is not working #789

Open JanssenBrm opened 5 months ago

JanssenBrm commented 5 months ago

The following error is generated whenever you try to use an openEO parameter in the max_cloud_cover argument of a load_collection call:

OpenEO batch job failed: PropertyConditionException(status_code=400, code='PropertyConditionInvalid', message="Expected parameter 'value' but got 'max_cloud_cover'", id='no-request')

In this file you can find the UDP definition of our BIOPAR service that can be used to replicate the issue. It is mainly on the following part of the UDP:

"y": {
"from_parameter": "max_cloud_cover"
}
image

If you would replace this part of the JSON with the following, the service is executing properly:

"y": 95

For reference, you can have a look at the following job on CDSE: j-240411069661443bac723a25a4cc9754

soxofaan commented 4 months ago

this is more an issue in the openeo-geopyspark-driver or openeo-python-driver: the UDF in question parameterizes the cloud_cover property, but the property evaluator does not support parameterized values I guess

bossie commented 3 months ago

Right, one of the arguments has to be a constant at the moment.

Non-trivial fix I think. :eyes: