refine GeopysparkCubeMetadata

Open-EO / openeo-geopyspark-driver

OpenEO driver for GeoPySpark (Geotrellis)

Apache License 2.0

26 stars 4 forks source link

Open bossie opened 2 weeks ago

bossie commented 2 weeks ago

A couple of issues:

it's unclear why GeopysparkCubeMetadata has spatial_extent and temporal_extent in addition to those in its dimensions;
it defines filter_bbox and filter_temporal methods whereas a similar filter_bands is defined in the CubeMetadata parent class instead;
timestamps are stringly typed instead of e.g. datetime.datetime.

soxofaan commented 1 week ago

Another thing that could be considered here: GeopysparkCubeMetadata currently subclasses from CollectionMetadata, but with https://github.com/Open-EO/openeo-python-client/issues/464 that should be changed to CubeMetadata