search

Open-EO / openeo-geopyspark-driver

OpenEO driver for GeoPySpark (Geotrellis)
Apache License 2.0
26 stars 4 forks source link

add support for apply_vectorcube udf #856 #882

Closed JeroenVerstraelen closed 5 days ago

JeroenVerstraelen commented 6 days ago

Related PR in python-client: https://github.com/Open-EO/openeo-python-client/pull/631

JeroenVerstraelen commented 6 days ago

Related PR in openeo-python-driver: https://github.com/Open-EO/openeo-python-driver/pull/314/files

soxofaan commented 6 days ago

after reviewing the other PRs in python client and python driver: do we actually need this #882 that adds a test in geopyspark driver actually? All functionality is actually elsewhere: python client and python driver, so the tests should be there

JeroenVerstraelen commented 6 days ago

after reviewing the other PRs in python client and python driver: do we actually need this #882 that adds a test in geopyspark driver actually? All functionality is actually elsewhere: python client and python driver, so the tests should be there

The test in the geopyspark driver is specifically to see if you can apply an udf on the output of raster_to_vector without any issues. Because previously that didn't work as expected.

soxofaan commented 6 days ago

ah ok indeed, raster_to_vector is the differentiating aspect here

soxofaan commented 5 days ago

Also to include in this PR: as it depends on python client and python driver changes, it should bump the version constraint of these dependencies in setup.py Which implies you should also bump the versions in

JeroenVerstraelen commented 5 days ago

All comments should be addressed now except for the extra tests in the python driver and client, those will be handled in this issue: https://github.com/Open-EO/openeo-python-driver/issues/315