search

Open-EO / openeo-gfmap

Generic framework for EO mapping applications building on openEO
Apache License 2.0
6 stars 1 forks source link

split_job_hex not working #166

Closed HansVRP closed 1 month ago

HansVRP commented 1 month ago

h3.geo_to_h3 seems to be no longer supported

HansVRP commented 1 month ago

I believe the function was renamed to latlng_to_cell, so it would be a small fix.

In addition there would be need of an integration test to ensure this function remains stable.

Thoughts @VincentVerelst ?

VincentVerelst commented 1 month ago

This seems to be a breaking API change in h3 from v4.0.0 onwards.

In our dependencies we don't specify any specific version of h3: https://github.com/Open-EO/openeo-gfmap/blob/main/pyproject.toml#L41

I propose the small fix and then pin our h3 dependency to v.4.0.0 (or a later one). Thoughts?

HansVRP commented 1 month ago

Sounds good.

HansVRP commented 1 month ago

Can you take this small bugfix up?