Closed clausmichele closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.20%. Comparing base (
9fcafef
) to head (f363715
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for checking this in the process implementation and bringing it up!
Anyhow, I have been wondering - does it make sense to rename the spatial coordinates after a reprojection in general? If data is reprojected from UTM to WGS84, the coordinates would be renamed to latitude and longitude by the reprojection and could stay like that, couldn't they?
What do you think about it?
The dimension labels should not be changed by this process, as specified in the process definition: https://processes.openeo.org/#resample_spatial
Oh, right - thanks for pointing it out - it just feels a bit counter-intuitive, doesn't it? But this is then more a question on the process definition level :)
LGTM!
Oh, right - thanks for pointing it out - it just feels a bit counter-intuitive, doesn't it? But this is then more a question on the process definition level :)
To me it makes sense, otherwise it could confuse the users if dimension labels change their values due to the projection/CRS you choose.
Fix for https://github.com/Open-EO/openeo-processes-dask/issues/228
Note: I add to add the default python language in the pre-commit configuration otherwise it didn't work in my environment.