search

Open-EO / openeo-processes-dask

Python implementations of many OpenEO processes, dask-friendly by default.
Apache License 2.0
19 stars 14 forks source link

resample_spatial missing dimensions causing a crash #249

Closed jzvolensky closed 3 months ago

jzvolensky commented 4 months ago

If dimensions are missing the resample_spatial crashes as it is out of range.

Fix + updated test is on the way

jzvolensky commented 4 months ago

Latest commit should fix this issue, @clausmichele @ValentinaHutter can you please review the test as I am not 100% sure it works the way I want it to. It should basically test the different combinations (x,y,bands) , (x,y,t), (x,y) with the parametrization. If that is not the case I can review it again. Thank you!

clausmichele commented 4 months ago

Hi @jzvolensky, I've reviewed the code and it is fine for me. Please change the status of the PR from draft to ready.

clausmichele commented 3 months ago

@jzvolensky tests are not passing anymore. From a quick check it seems for that for Python 3.9 the issue seems related to the odc package. For python 3.10 and 3.11 the error seems to be in how you are calling the reduce_dimension (check the reduce_dimension tests to see how to call it).

ValentinaHutter commented 3 months ago

We have been looking into the python3.9 issue this week and decided to remove python3.9 from the supported versions, Please pull from the latest version. :)