If we really need a new process, as I mentioned here, the processes that are modifying the datacube dimensionalities should go into either a reduce_dimension or an apply_dimension. For this case it should be used with apply_dimension.
The current implementation has some errors to fix:
This process has been recently added to the repo. However, I would like to mention some concerns I have:
reduce_dimension
or anapply_dimension
. For this case it should be used withapply_dimension
.dimension
variable, this fails as soon as thebands
dimension is not calledbands
.Test it with this code:
which returns:
ValueError: Type band is not understood
overlap_resolver
is being set with a band label. The overlap_resolver should be a function: https://github.com/Open-EO/openeo-processes-dask/blob/4390df5b4e010b9e4964c86bbd84a6c8911cb9d9/openeo_processes_dask/process_implementations/cubes/ddmc.py#L83@ValentinaHutter @koenifra