search

Open-EO / openeo-processes-python

A Python representation of (most) openEO processes
Apache License 2.0
11 stars 4 forks source link

`add_dimension` does not work #98

Closed clausmichele closed 2 years ago

clausmichele commented 2 years ago

The add_dimension process gets parsed from openeo-odc in this way:

_5_12 = oeop.add_dimension(**{'data': _3_3, 'name': 'bands', 'label': 'NDVI'})

However, the implementation does not have keywords arguments in the function definition. https://github.com/Open-EO/openeo-processes-python/blob/a0cf4558115bbb5264e283d10685e659c09393f6/src/openeo_processes/cubes.py#L966

I'll add a PR for this.

ValentinaHutter commented 2 years ago

I am sorry, I only realised this a few days ago. This is just a typo, where I used labels instead of label. This will be changed in the next update.

clausmichele commented 2 years ago

I've created a PR for this https://github.com/Open-EO/openeo-processes-python/pull/100

clausmichele commented 2 years ago

PR merged