Open-EO / openeo-processes

Interoperable processes for openEO's big Earth observation cloud processing.
https://processes.openeo.org
Apache License 2.0
48 stars 15 forks source link

Migrate to general data cube definition #382

Closed m-mohr closed 1 year ago

m-mohr commented 2 years ago

This goes through the existing processes and makes changes so that, if applicable, they work with vector cubes.

Tasks:

m-mohr commented 1 year ago

This is ready for review! 🥳

m-mohr commented 1 year ago

For another issue: Should we change the vector_ prefix for the vector-related processes to something else?

Edit: Thinking a bit more about it, I think vector_ is fine. We still have a vector data cube as input, only the dimension is using the geometry terminology. As the prefixes do usually reflect the type of data you are passing in (i.e. vector data cube), we can stick with the names. Also to preserve a bit of backward compatibility with some rare implementations.

soxofaan commented 1 year ago

For another issue: Should we change the vector_ prefix for the vector-related processes to something else?

Also: let's move that question to another issue, to unblock #382

m-mohr commented 1 year ago

This is also ready for final review. I hope that I have fixed all open issues sufficiently. If you see minor things that we can fix quickly, please mention them here. If you see larger issues to be discussed, maybe open a separate issue so that we can merge this and then work in smaller PRs that are easier to handle.

Additionally, the schema for vector data cubes has changed due to the changes in the other PRs (API, STAC etc.):

                {
                    "type": "object",
                    "subtype": "datacube",
                    "dimensions": [
                        {
                            "type": "geometries"
                        }
                    ]
                }

So the type is now geometries instead of vector.

@soxofaan @mkadunc @aljacob @clausmichele @jdries @dthiex @LukeWeidenwalker @pierocampa

m-mohr commented 1 year ago

Also: let's move that question to another issue, to unblock #382

See #397

m-mohr commented 1 year ago

@aljacob The naming is discussed in another issue: https://github.com/Open-EO/openeo-api/issues/479