Closed m-mohr closed 1 year ago
If I understand correctly, after that this PR will be merged, when a user will select a polygon aoi in a load_collection
process in the Web Editor there will be two processes added: load_geojson
and load_collection
?
In the Web Editor it would complicate things a bit as you'd need to add the load_geojson specifically to the model builder and then connect it to the temporal_extent parameter, but on the other hand it simplifies, because you can reuse it in subsequent processes like aggregate_spatial.
I just had a quick look at this PR, but this looks like a heavily breaking change.
Can't we just first add the load_geojson
option in non-breaking way (keep inline geosjon option),
and then in a later phase remove the original inline geojson option?
You can always still support geojson by adding the missing schema again. Having it still in here in 2.0 as deprecated would also mean new implementations would face it, which is not ideal.
8+
The PR has been updated according to the discussions today. Please review.
Applied the deprecation as discussed. Will create a new PR for load_geojson.
Streamlines the GeoJSON import #346
The load_geojson function probably needs a bit better description on how to construct the data cube.