Open-EO / openeo-processes

Interoperable processes for openEO's big Earth observation cloud processing.
https://processes.openeo.org
Apache License 2.0
49 stars 15 forks source link

Improve summary of order process #424

Closed soxofaan closed 1 year ago

soxofaan commented 1 year ago

spin-off from #409 :stuck_out_tongue:

m-mohr commented 1 year ago

A change here should probably be aligned with rearrange.

For me in this proposal it's not clear what the order is. This sounds a bit like whether it would return "ascending" or "descending" or "unsorted" and not the indices for the array in a sorted order ;-)

soxofaan commented 1 year ago

A change here should probably be aligned with rearrange.

Because rearrange uses "permutation" in its summary? I think that's fine.

For me in this proposal it's not clear what the order is. This sounds a bit like whether it would return "ascending" or "descending" or "unsorted"

Ok fair. An alternative, stealing from numpy argsort:

Get indices that would sort the array

FYI: what I don't like about the current summary "Create a permutation":

so "create a permutation" roughly sounds like "randomly shuffle the array" to me

m-mohr commented 1 year ago

@soxofaan I made a couple of changes to the PR, especially to link between the processes. Can you check whether this works for you?

soxofaan commented 1 year ago

yes it's better now

apparently I can approve this PR, I guess because I started it myself

m-mohr commented 1 year ago

True, I've just merged it now.