search

Open-EO / openeo-processes

Interoperable processes for openEO's big Earth observation cloud processing.
https://processes.openeo.org
Apache License 2.0
48 stars 17 forks source link

`resample_cube_spatial`: clarify if cropping spatially or not #509

Closed clausmichele closed 5 months ago

clausmichele commented 6 months ago

Process ID: resample_cube_spatial https://processes.openeo.org/#resample_cube_spatial

Describe the issue: Currently, there are two main implementations of resample_cube_spatial.

openeo-processes-dask: the output will have the same resolution and projection. The pixels will be aligned with the target datacube and the spatial dimensions labels will also match, i.e. the spatial extent of the output corresponds exactly to the spatial extent of the target. So, if the input covers a larger spatial extent, it is cropped to match the target (in the opposite situation, no data is padded).

VITO/CDSE (don't know where the implementation is at the moment): the behaviour is different, because the spatial dimension labels are not matching from some tests I recently did. So, from what I can understand, the process takes resolution, projection and alignment from the target, but then it doesn't restrict the output to the same spatial extent.

Proposed solution: Clarify if we have the output cube needs to have the same labels in the spatial dimensions, i.e. covering exactly the same area as the target datacube.

cc @soxofaan @jdries @ValentinaHutter

m-mohr commented 5 months ago

Community meeting: Cropping is not intended.

clausmichele commented 4 months ago

The implementation at VITO is also not fully compliant: https://forum.dataspace.copernicus.eu/t/resample-cube-spatial-inconsistent-behavior/948

m-mohr commented 4 months ago

Might be better to open an issue in their issue tracker.