Open-EO / openeo-processes

Interoperable processes for openEO's big Earth observation cloud processing.
https://processes.openeo.org
Apache License 2.0
48 stars 16 forks source link

Fix phenology example #72

Closed m-mohr closed 4 years ago

m-mohr commented 5 years ago

The Phenology example has invalid examples and is missing a description what the files are for.

Some problems I found in timeseries_udf.json:

Some of the issues also exist in evi_cube.json.

To make the examples easier to read, I'd also remove the parameters which hold their default values (e.g. "result": false or "crs": "EPSG:4326") or have floating point inconsistencies (e.g. 0.0006000000000000001)

Having invalid examples in the master branch will confuse users and therefore we need to either fix it or revert the changes in the next days.

ToDo list:

jdries commented 5 years ago

I started a pull request for this, but may still need to resolve some of the issues. I updated the process graphs, as they were not updated to the latest versions that the notebook generated. These graphs are in fact not needed by the notebook, but I was thinking that someone might find them useful as examples of advanced process graphs. Of course, this does require us to keep them up to date, so I'm fine with removing them if they cause issues.

m-mohr commented 5 years ago

I'm fine with having the graphs as they could indeed be useful for some, but only if you keep them up-to-date over time.

m-mohr commented 4 years ago

Example have been moved to openeo.org